Skip to content

unicode-table-generator refactors #145414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

unicode-table-generator refactors #145414

wants to merge 5 commits into from
+159 −153

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Aug 15, 2025

Split off from #145219

Kmeakin added 5 commits August 15, 2025 01:29
@Kmeakin
refactor: Include table sizes in comment at top of unicode_data.rs
c992245 
To make changes in table size obvious from git diffs
@Kmeakin
refactor: Include size of case conversion tables
69e1974 
Include the sizes of the `to_lowercase` and `to_uppercase` tables in the
total size calculations.
@Kmeakin
refactor: rewrite ranges_from_set
5d54ac5 
The `merge_ranges` function was very complicated and hard to understand.
Forunately, we can use `slice::chunk_by` to achieve the same thing.
@Kmeakin
refactor: generate_tests
30d1bc7 
Rewrite `generate_tests` to be more idiomatic.
@Kmeakin
refactor: Add tests for case conversions
c3ce079
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

library/core/src/unicode/unicode_data.rs is generated by
src/tools/unicode-table-generator via ./x run src/tools/unicode-table-generator. If you want to modify unicode_data.rs,
please modify the tool then regenerate the library source file with the tool
instead of editing the library source file manually.

@joshtriplett
Copy link
Member

r=me once CI goes green.

@Kmeakin
Copy link
Contributor Author

Kmeakin commented Aug 15, 2025

r? @joshtriplett

@rustbot rustbot assigned joshtriplett and unassigned thomcc Aug 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

@tgross35
Copy link
Contributor

tgross35 commented Sep 3, 2025

I took a look as well, LGTM too. Thanks for the clean commits.

@bors r=joshtriplett,tgross35

@bors
Copy link
Collaborator

bors commented Sep 3, 2025

📌 Commit c3ce079 has been approved by joshtriplett,tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 3, 2025
@tgross35
Rollup merge of rust-lang#145414 - Kmeakin:km/unicode-table-refactors…
17e2d38 
…, r=joshtriplett,tgross35

unicode-table-generator refactors

Split off from rust-lang#145219
@tgross35 tgross35 mentioned this pull request Sep 3, 2025
Open
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146141 - tgross35:rollup-vx6hx6n, r=tgross35
08780cf 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kmeakin @rustbot @joshtriplett @tgross35 @bors @thomcc